Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Array type #79

Merged
merged 39 commits into from
Feb 8, 2022
Merged

Added Array type #79

merged 39 commits into from
Feb 8, 2022

Conversation

Meowcolm024
Copy link
Collaborator

Added type Array[T] as a super type of tuples. Following: (a, b, c) <: Array[a | b | c] as in #63

Meowcolm024 and others added 28 commits January 15, 2022 14:47
@Meowcolm024
might be broken, but Conjunction seems working
bdd4fb7
@Meowcolm024
how to add build in QAQ
dd05441
@Meowcolm024
wired
6c2cb00
@LPTK
Fix Array type internal definition
9d8e101
@Meowcolm024
Merge pull request #1 from hkust-taco/yicong
e89cf25 
Fix Array type internal definition
@Meowcolm024
move to array-type
5039670
@Meowcolm024
Merge pull request #2 from hkust-taco/mlscript
d272722 
fetch upstream
@Meowcolm024
added tests
5465409
@Meowcolm024
Merge branch 'array-type' of github.com:Meowcolm024/mlscript into arr…
6ddb38a 
…ay-type
@Meowcolm024
becomes more wired
7a18f9e
@Meowcolm024
fix bug of solving constrains on tuple <! array
69d265f
@Meowcolm024
added tests for array type
39f44c3
@Meowcolm024
bring back tuple <: records
c5d0fba 
added tests
@Meowcolm024
Merge branch 'mlscript' of into hkust-taco-mlscript
aa89219
@Meowcolm024
Merge branch 'hkust-taco-mlscript' into array-type
cfb571a
@Meowcolm024
Merge branch 'hkust-taco:mlscript' into array-type
a2fe869
@Meowcolm024
update parser
dff6f6c
@Meowcolm024
update parser
1f5eb41
@Meowcolm024
added typer for array subscription
0034d6c
@Meowcolm024
simpl in Parser.
9d1e6e7
@LPTK
Include record of tuple fields in their normal form (TODO simplify th…
59610cd 
…em back!)
@Meowcolm024
added simpl in tuples
677ce3a
@Meowcolm024
added tests
4d3d74b
@Meowcolm024
bug fix in TyperHelper
b975081 
for field "_0"
@Meowcolm024
added more tests
266071d
@Meowcolm024
Merge branch 'mlscript' into array-type
2afdf1c
@Meowcolm024
clean up code & bug fix
d5c0e52
@Meowcolm024
fixed
5c28950
@Meowcolm024 Meowcolm024 requested a review from LPTK February 4, 2022 05:16
@Meowcolm024 Meowcolm024 self-assigned this Feb 4, 2022
@Meowcolm024 Meowcolm024 linked an issue Feb 4, 2022 that may be closed by this pull request
Add Array types #63
Closed
@Meowcolm024 Meowcolm024 marked this pull request as ready for review February 5, 2022 10:51
LPTK
LPTK requested changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@LPTK LPTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very impressive work, thanks!

I have many lower-level comments and change requests, but overall it looks good. Please go through all my comments and solve them.

shared/src/main/scala/mlscript/MLParser.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/NormalForms.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/NormalForms.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/TyperHelpers.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/TyperDatatypes.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/Typer.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/TyperDatatypes.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/TyperDatatypes.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/TyperHelpers.scala Outdated Show resolved Hide resolved
shared/src/main/scala/mlscript/helpers.scala Outdated Show resolved Hide resolved
@LPTK LPTK mentioned this pull request Feb 7, 2022
Closed
@Meowcolm024 Meowcolm024 requested a review from LPTK February 7, 2022 11:09
@LPTK
Copy link
Contributor

LPTK commented Feb 8, 2022

@Meowcolm024 Okay, we're almost there! But there are a bunch of old and new unresolved conversations. Please don't forget to mark these as resolved when you're sure you've resolved them. It'll helps us a lot.

LPTK
LPTK approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@LPTK LPTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay great. I'll squash-merge this now!

@LPTK LPTK merged commit 55b39ab into mlscript Feb 8, 2022
@LPTK LPTK deleted the array-type branch February 8, 2022 07:03
@LPTK LPTK mentioned this pull request Feb 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPTK LPTK LPTK approved these changes

Assignees

@Meowcolm024 Meowcolm024

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Array types
2 participants
@Meowcolm024 @LPTK