Add memoization #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds memoization and tests.
owst
suggested changes
Jan 19, 2023
| config.to_prepare do | ||
| ActiveSupport.on_load :action_controller do | ||
| include KnockoutAssetsHelper | ||
| helper_method :knockout_assets |
There was a problem hiding this comment.
On reload, you presumably want to bust the knockout_assets cache - will that happen?
| module KnockoutAssetsHelper | ||
| include ::Memery | ||
|
|
||
| memoize def knockout_assets(options = {}) | ||
| options = { | ||
| exclude: nil, | ||
| preload: true, | ||
| include: /.*\.(png|gif|jpg|jpeg|bmp|svg)/, |
There was a problem hiding this comment.
Should these file extensions be anchored to the end of path as /.*\.(png|...|svg)$/?
There was a problem hiding this comment.
Also you can probably drop the .* at the start
| @@ -0,0 +1,7 @@ | |||
| class ApplicationController < ActionController::Base | |||
There was a problem hiding this comment.
I can't comment on the above assets in the GH diff, but if this is a public gem, I don't think we should include other companies' logos
| @@ -0,0 +1,2 @@ | |||
| <%= knockout_assets %> | |||
| <% knockout_assets # Check calling it a second time is memoized %> | |||
There was a problem hiding this comment.
Is it valid to call it twice? Why/how does that happen? Should it be an error instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds memoization and tests.