Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Shop_GiveClientItem (probably unfinished, need tests) #112

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

RusJJ
Copy link

@RusJJ RusJJ commented Jan 1, 2022

No description provided.

RusJJ added 4 commits January 1, 2022 18:11
Bump version
Fixed for the latest version of SteamWorks
PROBABLY unfinished
Fixes Shop_GiveClientItem by handling third param named "count"
Revert one change in a code
Copy link
Contributor

@TiBarification TiBarification left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which version of Steamworks you're using? Your changes fails by CI/CD not only on SM 1.11 build (which is allowed to fail), but also on SM 1.10 build.

https://app.travis-ci.com/github/FD-Forks/Shop-Core/jobs/553970168

@@ -2,9 +2,9 @@ stock const char API_KEY[] = "e34fa2f3adb922bf76fb7b06807caa3c";
stock const char URL[] = "http://stats.tibari.ru/api/v1/add_server";

/* Stats pusher */
public int SteamWorks_SteamServersConnected()
public void SteamWorks_SteamServersConnected()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to change it

{
int iIp[4];
char iIp[4];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, why you have changed it

@RusJJ
Copy link
Author

RusJJ commented Jan 9, 2022

Which version of Steamworks you're using?

https://github.com/komashchenko/SteamWorks

@TiBarification
Copy link
Contributor

Which version of Steamworks you're using?

https://github.com/komashchenko/SteamWorks

Why you're using this fork instead of original repository? Also i see this fork is marked as "read-only", I don't think it have any support.

For building we're use http://users.alliedmods.net/~kyles/builds/SteamWorks/ builds and *.inc files for compilation

@TiBarification
Copy link
Contributor

TiBarification commented Jan 9, 2022

@RusJJ please take a look into https://github.com/FD-Forks/Shop-Core/blob/master/.travis.yml file, there are instructions for compilation shop core.

@TiBarification TiBarification marked this pull request as draft January 9, 2022 18:23
@TiBarification TiBarification marked this pull request as ready for review April 1, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants