[ON HOLD] 555 blognews hubs multiple filters #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
|
aem-code-sync
bot
temporarily deployed
to
555-blognews-hubs-multiple-filters
aem-code-sync
bot
temporarily deployed
to
555-blognews-hubs-multiple-filters
aem-code-sync
bot
temporarily deployed
to
555-blognews-hubs-multiple-filters
|
sharanagoudapatil
requested review from
mhaack,
duynguyen,
rgravitvl and
davenichols-DHLS
|
@davenichols-DHLS - I've addressed the above comments. Please have a look. Thanks. |
duynguyen
reviewed
Dec 20, 2023
| @@ -174,6 +236,7 @@ export default async function decorate(block) { | |||
| block.append(cardList); | |||
| // render cards article style | |||
| } else { | |||
| // block.classList.add('space-x-2'); | |||
There was a problem hiding this comment.
can we remove if this is not needed?
duynguyen
reviewed
Dec 20, 2023
| function toggleFilter(event) { | ||
| const isOpen = event.target.parentElement.getAttribute('aria-expanded'); | ||
| if (JSON.parse(isOpen)) { | ||
| event.target.parentElement.parentElement.focus(); |
There was a problem hiding this comment.
I wonder if we should use display none (CSS) here instead of focus / blur, which relies on JS events hence requires you to add some latency after the focus (click).
duynguyen
reviewed
Dec 20, 2023
| ); | ||
| inputEl.addEventListener('click', (e) => { | ||
| window.location.href = e.target.parentElement.getAttribute('href'); | ||
| }); | ||
| if (toClassName(keyword).toLowerCase() === activeTag) { |
There was a problem hiding this comment.
as you're creating input[radio], this if might not be needed anymore. something like this would capture the "checked" field:
document.querySelector(`input[name=${tagName}Radio][value=${keyword}]`).setAttribute('checked', true);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #555
Test URLs: