Replace template<class> with template<typename> #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drupol
reviewed
May 17, 2022
| @@ -206,6 +206,8 @@ \subsection{Equational Reasoning} | |||
| fmap g Nothing | |||
| = { definition of fmap } | |||
| fmap g (fmap f Nothing) | |||
| = { definition of composition } | |||
There was a problem hiding this comment.
This snippet seems to be out of scope of this PR, is it intended ?
There was a problem hiding this comment.
It was intended, but you're right that it's out of scope - I'll remove it.
Also thanks for the reminder, I completely forgot about this PR. I'll fix it this week.
|
Dear @matssson, Do you plan to implement the changes in this PR ? Thanks |
|
I fixed the changes now in a new PR #309 I redid the trailing whitespace part since there were a lot of changes since the original PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the book focuses heavily on types, I think that the C++ keyword typename is more appropriate, clear and avoids confusion for those less experienced with C++, and I think it's generally good practice to use typename instead of the overloaded meaning of class.
I also added a missing step in the composition argument for fmap Nothing and fixed some whitespace formatting.
There is trailing whitespace in the licence file and in errata-1.0.0.md, but I didn't change them since I think it's more interesting for the readers to know when they were last updated properly.