-
Notifications
You must be signed in to change notification settings - Fork 65
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #165 from hmrc/PLATUI-1736_adr_scala_cross_compila…
…tion PLATUI-1736: Add adr with decision not to allow scala cross compilation
- Loading branch information
Showing
1 changed file
with
34 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
# play-ui scala 2.13 cross compilation | ||
|
||
* Status: accepted | ||
* Date: 2022-05-19 | ||
|
||
## Context and Problem Statement | ||
|
||
The need to allow scala cross compilation for scala version 2.13 | ||
|
||
## Decision Drivers | ||
|
||
* as new scala versions are released we are in the process of allowing cross compilation between these new scala versions, | ||
for all our libraries and services so when service teams that use our libraries/services update their scala versions our libraries/services will support it. | ||
* we don't want new services to start using play-ui | ||
* we want to be able to easily change our mind if we need to | ||
|
||
## Considered Options | ||
|
||
* Do not allow scala cross compilation for scala version 2.13 | ||
* Add scala cross compilation for scala version 2.13 | ||
|
||
## Decision Outcome | ||
|
||
Chosen option "Do not allow scala cross compilation" because play-ui is a deprecated library, and we do not actively support development for it anymore. | ||
|
||
### Positive Consequences | ||
|
||
* As adding scala cross compilation for version 2.13 would be implicitly supporting this deprecated library, we would not want to give service teams that are still using this library the wrong impression that we are still actively supporting it. | ||
* By adding scala cross compilation for version 2.13, we could be creating more work for ourselves as there could be issues when service teams still actively using this library upgrade there scala version to 2.13. We would end up supporting those queries which we shouldn't do as we do not actively support this deprecated library anymore. | ||
* There wouldn't be risk of needing to add cross compilation and not being able to- we've checked if we could if we wanted to | ||
|
||
### Negative Consequences | ||
|
||
* As there are service teams that are actively using this library and cannot for some reason move away from using this library, there might be a time when we would need to support scala version 2.13 for those service teams. |