Merge pull request #6 from hnakamur/use_query_selector_to_get_link_text

Use query selector to get link text
hnakamur · Aug 23, 2017 · f5054f8 · f5054f8
2 parents d494ccf + 37e6964
commit f5054f8
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 24 deletions.
diff --git a/README.md b/README.md
@@ -77,6 +77,14 @@ Here are examples:
 "{{title.s("\"","&quot;").s("\\[","&#91;")}}":{{url}}
 ```
 
+## KNOWN LIMITATIONS
+
+* Due to web extension API limitations, this extension does not work as users might expect.
+* You cannot use the toolbar nor the keyboard shortcut if you want to copy a link URL. With those two, the URL always becomes the page URL.
+* Due to security reason, the limitation becomes severer on about: pages and addons.mozilla.org pages.
+  * You cannot use the context menus nor the keyboard shortcut on those pages.
+  * You can use the toolbar to copy the URL, but the text always become the page title even if you select some text.
+
 ## License
 MIT License.
 Source codes are hosted at [Github](https://github.com/hnakamur/FormatLink-Firefox)

diff --git a/background.js b/background.js
@@ -28,6 +28,27 @@ function copyTextToClipboard(text) {
   });
 }
 
+function tryToGetLinkSelectionText(tab, url, text) {
+  if (text) {
+    return Promise.resolve(text);
+  }
+  return browser.tabs.sendMessage(tab.id, {"method": "getSelection"}).
+  then(response => {
+    var selText = response.selection;
+    if (selText) {
+      return selText;
+    }
+    return browser.tabs.executeScript(tab.id, {
+      code: `
+        var link = document.querySelector('a[href="${url}"]');
+        link ? link.innerText.trim() : "";
+      `
+    }).then(response => {
+      return response[0];
+    });
+  });
+}
+
 gettingOptions().then(options => {
   createContextMenus(options);
 
@@ -43,7 +64,8 @@ gettingOptions().then(options => {
         var title = tab.title;
         var text = info.selectionText;
         try {
-          if (text) {
+          tryToGetLinkSelectionText(tab, url, text).
+          then(text => {
             var formattedText = formatURL(format, url, title, text);
             copyTextToClipboard(formattedText).
             then(() => {
@@ -52,29 +74,7 @@ gettingOptions().then(options => {
                 saveDefaultFormat(formatID);
               }
             });
-          } else {
-            browser.tabs.sendMessage(tab.id, {"method": "getSelection"}).
-            then(response => {
-              text = response.selection;
-              var formattedText = formatURL(format, url, title, text);
-              copyTextToClipboard(formattedText).
-              then(() => {
-                var ctrlPressed = info.modifiers.includes('Ctrl');
-                if (ctrlPressed) {
-                  saveDefaultFormat(formatID);
-                }
-              });
-            }).catch(reason => {
-              var formattedText = formatURL(format, url, title);
-              copyTextToClipboard(formattedText).
-              then(() => {
-                var ctrlPressed = info.modifiers.includes('Ctrl');
-                if (ctrlPressed) {
-                  saveDefaultFormat(formatID);
-                }
-              });
-            });
-          }
+          });
         } catch (e) {
           console.error("FormatLink extension failed to copy URL to clipboard.");
         }