Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Psychic from committing a suicide: the object already cleanup its resources when going out of scope or deleted externally by the user #126

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Prevent Psychic from committing a suicide: the object already cleanup its resources when going out of scope or deleted externally by the user #126

merged 1 commit into from
Aug 8, 2024

Conversation

mathieucarbou
Copy link
Collaborator 

  #7  0x400d49fd in PsychicHttpServer::~PsychicHttpServer() at /Users/mat/Data/Workspace/forks/PsychicHttp/src/PsychicHttpServer.cpp:56
  #8  0x4018014b in PsychicHttpServer::destroy(void*) at /Users/mat/Data/Workspace/forks/PsychicHttp/src/PsychicHttpServer.cpp:61 (discriminator 1)
  #9  0x4010a1a2 in httpd_stop at /home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/esp-idf/components/esp_http_server/src/httpd_main.c:558
  #10 0x400d4190 in PsychicHttpServer::stop() at /Users/mat/Data/Workspace/forks/PsychicHttp/src/PsychicHttpServer.cpp:113

@mathieucarbou
Prevent Psychic from committing a suicide: the object already cleanup…
40d47e4 
… its resources when going out of scope or deleted externally by the user
@hoeken hoeken merged commit 7c49d3d into hoeken:master Aug 8, 2024
3 checks passed
mathieucarbou added a commit to mathieucarbou/hoeken-PsychicHttp that referenced this pull request Aug 8, 2024
@mathieucarbou
Revert "Prevent Psychic from committing a suicide: the object already…
5118f61 
… cleanup its resources when going out of scope or deleted externally by the user (hoeken#126)"

This reverts commit 7c49d3d.
hoeken pushed a commit that referenced this pull request Aug 8, 2024
@mathieucarbou
Fix suicide bug when stopping (#128)
8257758 
* Revert "Prevent Psychic from committing a suicide: the object already cleanup its resources when going out of scope or deleted externally by the user (#126)"

This reverts commit 7c49d3d.

* Fix suicide bug when stopping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieucarbou @hoeken