Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending through TCP, OSC 1.0 uses a packet length header (PLH) (four bytes at the start of outgoing data) to indicate to the receiver how long the packet will be. The current TCP transport in JavaOSC doesn't add this PLH to outgoing data, so other OSC-compliant apps won't process the data correctly; and it doesn't read this PLH from incoming data, so it won't process the data from other OSC-compliant apps correctly.
This PR correctly adds the PLH to outgoing data. For incoming data, it simply discards the PLH. A more complete solution would use the PLH to correctly process incoming OSC messages that are split across multiple TCP packets.