Add opts.persistentKey (to avoid writing key to disk) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
C'mon Windows! I know you can do it |
mafintosh
reviewed
Feb 17, 2023
| @@ -90,7 +91,7 @@ module.exports = class Corestore extends EventEmitter { | |||
| if (err && err.code !== 'ENOENT') return reject(err) | |||
| if (err || st.size < 32 || this._overwrite) { | |||
| const key = this.primaryKey || crypto.randomBytes(32) | |||
| return this._keyStorage.write(0, key, err => { | |||
| return this._keyStorage.write(0, this.persistentKey ? key : b4a.alloc(0), err => { | |||
There was a problem hiding this comment.
dont write anything if you are not persisting. just return before instead and resolve
There was a problem hiding this comment.
Right, the issue is that we still need to lock from the storage
There was a problem hiding this comment.
Although I don't remember if without writing then the file exists anyway, maybe it does, will check later!
mafintosh
reviewed
Feb 17, 2023
| @@ -25,6 +25,7 @@ module.exports = class Corestore extends EventEmitter { | |||
| this.cores = root ? root.cores : new Map() | |||
| this.cache = !!opts.cache | |||
| this.primaryKey = opts.primaryKey || null | |||
| this.persistentKey = opts.persistentKey !== false | |||
There was a problem hiding this comment.
could use a better name i think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.