Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expressed changed status as return statement #243

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

telamon
Copy link

@telamon telamon commented Jan 29, 2025

In order to tell if "remote changed" callback is executed deferred or immediately;

When remote can be changed immediately I modified udx_stream_change_remote() to return 1 instead of invoking the callback.

Return values are now:

<0: Error during change
0: Success, change deferred
1: Success, change immediate
breaks udx-native <1.17.x

on_change_callback is now only called when return signals 0 = change deferred.

@telamon telamon changed the title expressed changed status as return statement [WAIT, don't merge] expressed changed status as return statement Jan 29, 2025
@telamon telamon force-pushed the feat/change_remote-no-immediate-callback branch from 2b4223c to 61fea24 Compare January 29, 2025 15:45
@telamon telamon changed the title [WAIT, don't merge] expressed changed status as return statement [hold] expressed changed status as return statement Jan 29, 2025
@telamon telamon changed the title [hold] expressed changed status as return statement Expressed changed status as return statement Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants