Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple extreme days #25

Merged
merged 9 commits into from
Dec 6, 2018
Merged

Simple extreme days #25

merged 9 commits into from
Dec 6, 2018

Conversation

holgerteichgraeber
Copy link
Owner

@holgerteichgraeber holgerteichgraeber commented Dec 4, 2018

Simple extreme day selection. The process is outlined in workflow_example_extr.jl. It consists of selection, and representation modification.

  • The features of simple extreme days are defined as a struct that contains all features where they how they can be different (as of Constantin's MS thesis)
  • The extreme days themselves are defined as ClustInputData structs
  • They get weight 0 if feasibility steps, and weight of the day in the input data (usually 1) if append method
  • All methods are implemented such that they can take in one or several extreme days (through multiple dispatch).

Adresses #18.

Copy link
Collaborator

@YoungFaithful YoungFaithful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need a little more time to fully get through it, but it looks great on the first sight.

@@ -33,3 +33,4 @@ include(joinpath("utils","load_data.jl"))
include(joinpath("optim_problems","run_opt.jl"))
include(joinpath("clustering","run_clust.jl"))
include(joinpath("clustering","exact_kmedoids.jl"))
include(joinpath("clustering","extreme_vals.jl"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if I should also move attribute weighting here...

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that idea

Copy link
Collaborator

@YoungFaithful YoungFaithful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need a little more time to fully get through it, but it looks great on the first sight.


# define simple extreme days of interest
ev1 = SimpleExtremeValueDescr("wind-dena42","max","absolute")
ev2 = SimpleExtremeValueDescr("pv-dena42","min","integral")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like integral or absolute option

Copy link
Collaborator

@YoungFaithful YoungFaithful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the workflow. I'd like to see the SimpleExtremeDescr in the clust_config and the extr_ind in clust_results, what do you think?

ev3 = SimpleExtremeValueDescr("el_demand-dena21","max","absolute")
ev = [ev1, ev2, ev3]
# simple extreme day selection
ts_input_data_mod,extr_vals,extr_idcs = simple_extr_val_sel(ts_input_data,ev;rep_mod_method="feasibility")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd like to see ev in the clust_config

extr_value_descr::SimpleExtremeValueDescr;
rep_mod_method::String="feasibility"
)
return simple_extr_val_sel(data,[extr_value_descr];rep_mod_method=rep_mod_method)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

function simple_extr_val_ident(data::ClustInputData,
extreme_value_descr::SimpleExtremeValueDescr)
return simple_extr_val_ident(data, extreme_value_descr.data_type; extremum=extreme_value_descr.extremum, peak_def=extreme_value_descr.peak_def)
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really enjoy your usage of the multiple dispatch

@YoungFaithful YoungFaithful merged commit 39fa75a into master Dec 6, 2018
@holgerteichgraeber holgerteichgraeber deleted the extremeDays branch December 8, 2018 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants