Update deps (and remove inner_cotton and excoveralls) #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs some maintenance tasks:
About inner_cotton and excoveralls
I understand the maintainer developed
inner_cotton
, so this may be controversial. The reason I removed it is because there were some compiler errors withcredo
andssl_verify_fun
that were fixed by updating their versions, which was easier to do without first updating the upstreaminner_cotton
dependency. I think more dependencies adds fragility to a project, and this is a very simple library, so would benefit from as few dependencies as possible. In this case, I replacedinner_cotton
by usingcredo
anddialyxir
directly, and also made the necessary update tossl_verify_fun
.I removed
excoveralls
, because the coverage was only 40% anyway, so I think the dependency was adding only a maintenance burden for this project.