Skip to content

Commit

Permalink
Merge branch 'main' into feat/guide/app-structure-dnas
Browse files Browse the repository at this point in the history
  • Loading branch information
pdaoust authored Jan 31, 2025
2 parents 2646276 + 0ed865a commit 4557f70
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 3 deletions.
15 changes: 14 additions & 1 deletion .github/workflows/spellcheck.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: 'Check spelling'
on: # rebuild any PRs and main branch changes
pull_request:
push:
branches:
- main

jobs:
spellcheck: # run the action
Expand All @@ -16,4 +18,15 @@ jobs:
with:
root: 'src'
files: '**/*.{json5,njk,md}'
incremental_files_only: false
incremental_files_only: false

ci_pass:
if: ${{ always() }}
runs-on: "ubuntu-latest"
needs:
- spellcheck
steps:
- name: check status
uses: re-actors/alls-green@release/v1
with:
jobs: ${{ toJSON(needs) }}
4 changes: 2 additions & 2 deletions src/pages/resources/upgrade/upgrade-holochain-0.4.md
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ The biggest change for 0.4 is that some features are marked `unstable` and aren'
**If your DNA needs to call a host function that depends on an unstable feature**, you'll need to do two things:
1. [Build a custom Holochain binary](https://github.com/holochain/holonix?tab=readme-ov-file#customized-holochain-build) with both the specific feature you need (see the list above) and `unstable-functions` enabled.
2. Enable the `unstable-functions` flag for the `hdi` and `hdk` dependencies in your zomes' `Cargo.toml` files:
2. Enable the `unstable-functions` flag for the `hdi` and `hdk` dependencies in your zomes' `Cargo.toml` files, and enable the `unstable-countersigning` flag for the `hdk` dependency if you need it:

```diff:toml
[dependencies]
Expand All @@ -157,7 +157,7 @@ The biggest change for 0.4 is that some features are marked `unstable` and aren'
```diff:toml
[dependencies]
-hdk = { workspace = true }
+hdk = { workspace = true, features = ["unstable-functions"] }
+hdk = { workspace = true, features = ["unstable-functions", "unstable-countersigning"] }
```
Note that you'll need to make sure your users are running your custom conductor binary. If you compile your zomes without `unstable-functions` enabled for `hdi` or `hdk`, users with the flag enabled in Holochain will still be able to use your hApp, but if you compile your zomes _with_ `unstable-functions`, users with the flag(s) disabled won't be able to use your hApp.
Expand Down

0 comments on commit 4557f70

Please sign in to comment.