App structure: DNAs page #516
Open
+863
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ucture-zome-functions
…e/app-structure-dnas
pdaoust
force-pushed
the
feat/guide/app-structure-dnas
branch
from
005aa7c to
994c997
Compare
jost-s
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Really long PR that includes much more than the issue is about. I suppose this is based off of another branch that addresses the other issues, so I haven't reviewed callbacks and zomes. I did review the DNA part and glossed over the relaxed ordering parts for entries. I haven't run the code examples.
The DNA part looks good to me with a few change requests.
This was referenced Jan 23, 2025
Co-authored-by: Jost <[email protected]>
…docs-pages into feat/guide/app-structure-dnas
jost-s
previously approved these changes
Jan 30, 2025
this was supposed to already happen; got lost somehow Co-authored-by: Jost <[email protected]>
jost-s
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All about DNAs. Closes #488. Depends on #512. Don't review until those are merged, cuz otherwise this PR will seem bigger than it really is.