feat(kitsune2): add top-level crate kitsune2 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jost-s
force-pushed
the
feat/add-top-level-kitsune-builder
branch
4 times, most recently
from
834dfbf to
dd92ea0
Compare
neonphog
reviewed
Jan 31, 2025
neonphog
reviewed
Jan 31, 2025
neonphog
reviewed
Jan 31, 2025
neonphog
reviewed
Jan 31, 2025
neonphog
reviewed
Jan 31, 2025
neonphog
reviewed
Jan 31, 2025
jost-s
force-pushed
the
feat/add-top-level-kitsune-builder
branch
5 times, most recently
from
2d79dec to
2e5294c
Compare
ThetaSinner
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Mostly looking good. I'm pretty sure the gossip integration tests aren't covering what they were before. I think they probably need some more adjustment to work with the automatic initiation but I do want to be sure they're still testing what they were supposed to
jost-s
commented
Feb 3, 2025
jost-s
force-pushed
the
feat/add-top-level-kitsune-builder
branch
4 times, most recently
from
a3c773b to
e947d0c
Compare
jost-s
force-pushed
the
feat/add-top-level-kitsune-builder
branch
from
e947d0c to
b203ed1
Compare
|
I've removed the kitsune2 test from this PR. It wasn't stable. The rest is good to go in. |
ThetaSinner
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a top-level crate called "kitsune2" with a production default builder. There's a full integration test using the builder.
The test is flaky with higher number of ops.
and I'm asking here first before going about the debugging myself. When the number of ops to be exchanged during gossip is increased to about 100 each, the following error happens almost always:Fixing the error will be part of another branch.
Famous error that we spotted in Holochain too, I believe.
resolved #79