Op data limit tests #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThetaSinner
commented
Feb 4, 2025
ThetaSinner
commented
Feb 4, 2025
ThetaSinner
commented
Feb 4, 2025
ThetaSinner
commented
Feb 4, 2025
jost-s
approved these changes
Feb 4, 2025
…would overwrite the stored_at time
ThetaSinner
force-pushed
the
op-data-limit-tests
branch
from
03096bd to
1ba1134
Compare
neonphog
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests the previous PR -> #94
Some minor improvements needed in the mem peer store to support this change, I'll comment on those separately.
I think this raises an important problem though. I still want these tests in but I think I should change how I've applied limits. It shouldn't apply in the middle of a time slice because if a time slice grows larger than the limit, we'll never be able to sync it. So I think I should roll back the code that applies limits in the op store and does a soft application of the limit in the DHT code that calls the op store. That way we might return more op ids than the other side wanted but we won't get stuck on a time slice. It's an edge case really, for when there's more data around, but I think it's easier to fix now.