Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate unit tests and run them in ci #170

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

c12i
Copy link
Collaborator

@c12i c12i commented Jan 2, 2024

This PR removes duplicate unit tests in templates.rs and refactors existing unit tests. Also, the unit tests are now run in a new cargotest workflow.

@c12i c12i requested a review from ThetaSinner January 2, 2024 21:48
@c12i c12i added the ShouldBackport/0.1 This change should be backported to develop-0.1 label Jan 2, 2024
.github/workflows/test.yaml Outdated Show resolved Hide resolved
.github/workflows/test.yaml Outdated Show resolved Hide resolved
src/templates.rs Show resolved Hide resolved
@ThetaSinner ThetaSinner added the ShouldBackport/0.2 This change should be backported to develop-0.2 label Jan 3, 2024
Copy link
Collaborator

@guillemcordoba guillemcordoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c12i is right, those tests are duplicated. In this PR I moved them here, so this PR looks fine to me.

Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆

@c12i c12i merged commit 1bd14e8 into holochain:develop Jan 4, 2024
2 checks passed
c12i added a commit to c12i/scaffolding that referenced this pull request Jan 11, 2024
Remove duplicate unit tests and run them in ci
c12i added a commit to c12i/scaffolding that referenced this pull request Jan 11, 2024
Remove duplicate unit tests and run them in ci
@c12i c12i removed ShouldBackport/0.2 This change should be backported to develop-0.2 ShouldBackport/0.1 This change should be backported to develop-0.1 labels Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants