Fix build command's exit code (#85)

I.e. don't appear to succeed when actually failing.

nbsite/cmd.py

@@ -2,6 +2,7 @@
 import glob
 import re
 import sys
+import subprocess
 from os.path import dirname
 from collections import ChainMap
 
@@ -25,14 +26,13 @@ def init(project_root='',doc='doc'):
 # maybe add task dependencies
 
 def fix_links(output):
-    # TODO: temp hack
-    os.system("nbsite_fix_links.py %s"%output)
+    subprocess.check_call(["nbsite_fix_links.py",output])
+
 
 def build(what,output,project_root='',doc='doc',examples='examples',examples_assets="assets"):
     # TODO: also have an overwrite flag
     paths = _prepare_paths(project_root,examples=examples,doc=doc,examples_assets=examples_assets)
-    # TODO: temp hack
-    os.system('sphinx-build -b %s %s %s'%(what,paths['doc'],output))
+    subprocess.check_call(["sphinx-build","-b",what,paths['doc'],output])
     if 'examples_assets' in paths:
         build_assets = os.path.join(output,examples_assets)
         print("Copying examples assets from %s to %s"%(paths['examples_assets'],build_assets))

nbsite/nbbuild.py

@@ -55,20 +55,6 @@ def kc(self,v):
         if self._ipython_startup is not None:
             msg_id = self._kc.execute( # noqa: a mess
                 self._ipython_startup,silent=False,store_history=False,allow_stdin=False,stop_on_error=True)
-# you can attempt to debug your startup code with this hack...            
-#            exec_reply = self._wait_for_reply(msg_id, self._ipython_startup)
-#            while True:
-#                msg = self.kc.iopub_channel.get_msg()
-#                if msg['parent_header'].get('msg_id') != msg_id:
-#                    continue
-#                else:
-#                    try:
-#                        output = output_from_msg(msg)
-#                    except:
-#                        continue
-#                    if output.output_type == 'error':
-#                        raise ValueError("Startup code failed: %s %s\n%s"%(output.ename,output.evalue,output.traceback))
-#                    break
 
 
 try: