Numpy 2.0 support #1306
Merged
Numpy 2.0 support #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
commented
Nov 6, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1306 +/- ##
=======================================
Coverage 85.63% 85.63%
=======================================
Files 51 51
Lines 11286 11286
=======================================
Hits 9665 9665
Misses 1621 1621 |
philippjfr
reviewed
Nov 6, 2023
datashader/datashape/coretypes.py
Outdated
| @@ -779,7 +779,7 @@ def from_numpy_dtype(self, dt): | |||
| elif np.issubdtype(dt, np.timedelta64): | |||
| unit, _ = np.datetime_data(dt) | |||
| return TimeDelta(unit=unit) | |||
| elif np.issubdtype(dt, np.unicode_): | |||
| elif np.__version__[0] < "2" and np.issubdtype(dt, np.unicode_): | |||
There was a problem hiding this comment.
Does numpy2 not have nay unicode dtypes?
There was a problem hiding this comment.
No, the recommendation is to use np.str_ instead, but this is checked further down, which is why I did it this way.
hoxbro
commented
Feb 2, 2024
philippjfr
approved these changes
Apr 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found with the latest release of ruff and this command
ruff check . --preview --select=NPY201 --fix