Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read_ regex on export #1064

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Fix read_ regex on export #1064

merged 1 commit into from
Feb 19, 2025

Conversation

ahuang11
Copy link
Contributor

With the new sqlglot changes, it converted read_csv to READ_CSV

Which caused downloading the file and running the cells to output:
IOException: IO Error: No files found that match the pattern "passengers.csv"

@ahuang11 ahuang11 requested a review from philippjfr February 18, 2025 18:23
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.51%. Comparing base (1dd6cee) to head (52e9ef8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1064   +/-   ##
=======================================
  Coverage   57.51%   57.51%           
=======================================
  Files         109      109           
  Lines       14291    14291           
=======================================
  Hits         8220     8220           
  Misses       6071     6071           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahuang11 ahuang11 changed the title Fix read regex Fix read_ regex on export Feb 19, 2025
@philippjfr philippjfr merged commit 4f14c6e into main Feb 19, 2025
12 checks passed
@philippjfr philippjfr deleted the read_regex branch February 19, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants