Raise AttributeError when attempting to set value on an rx obj #1022
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1022 +/- ##
==========================================
+ Coverage 87.25% 87.26% +0.01%
==========================================
Files 9 9
Lines 4928 4932 +4
==========================================
+ Hits 4300 4304 +4
Misses 628 628 ☔ View full report in Codecov by Sentry. |
| @@ -1961,6 +1961,11 @@ def _eval_operation(self, obj, operation): | |||
| obj = fn(obj, *resolved_args, **resolved_kwargs) | |||
| return obj | |||
|
|
|||
| def __setattr__(self, name, value): | |||
| if name == "value": | |||
There was a problem hiding this comment.
Why only value?
And what if the underlying object itself has a value attribute?
There was a problem hiding this comment.
And what if the underlying object itself has a value attribute?
I don't think this has any consequence? Currently, for an object that has a value attribute, rx(obj).value returns a reactive expression. Setting rx(obj).value sets value on the reactive expression, not on the underlying object, which can be done with rx(obj).rx.value = <value>. Let me know if I got this wrong.
Why only value?
Because that's the most error-prone attribute in my opinion and I don't want to restrict __setattr__ too much beyond that.
Resolves #869