fix(kubernetes): non-string annotation values cause the annotation ma…

…p in a manifest's Go representation to be empty (#175)

* update go version in workflow

* force annotation values to be string when converting to manifest to kubernetes unstructured.Unstructured

---------

Co-authored-by: abe garcia <[email protected]>

.github/workflows/build.yml

@@ -1,6 +1,7 @@
 name: Build
 
 on:
+  workflow_dispatch:
   push:
     branches: [master]
   pull_request:
@@ -25,7 +26,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v4
         with:
-          go-version: ^1.13
+          go-version: "1.18"
 
       - name: Get dependencies
         run: |

internal/api/core/kubernetes/deploy.go

@@ -50,6 +50,7 @@ func (cc *Controller) Deploy(c *gin.Context, dm DeployManifestRequest) {
 		clouddriver.Error(c, http.StatusBadRequest, err)
 		return
 	}
+
 	// Merge all list element items into the manifest list.
 	manifests, err = mergeManifests(manifests)
 	if err != nil {

internal/api/core/kubernetes/deploy_test.go

@@ -48,6 +48,31 @@ var _ = Describe("Deploy", func() {
 		})
 	})
 
+	When("the manifest contains a non-string annotation", func() {
+		BeforeEach(func() {
+			deployManifestRequest.Manifests = []map[string]interface{}{
+				{
+					"kind":       "ConfigMap",
+					"apiVersion": "v1",
+					"metadata": map[string]interface{}{
+						"annotations": map[string]interface{}{
+							kubernetes.AnnotationSpinnakerMaxVersionHistory: 10,
+							kubernetes.AnnotationSpinnakerReplaced:          true,
+						},
+						"name": "test",
+					},
+				},
+			}
+		})
+
+		It("suceeds and annotations are set properly", func() {
+			Expect(c.Writer.Status()).To(Equal(http.StatusOK))
+			u := fakeKubeClient.ReplaceArgsForCall(0)
+			Expect(u.GetAnnotations()).To(HaveKeyWithValue(kubernetes.AnnotationSpinnakerMaxVersionHistory, "10"))
+			Expect(u.GetAnnotations()).To(HaveKeyWithValue(kubernetes.AnnotationSpinnakerReplaced, "true"))
+		})
+	})
+
 	Context("the kind is a list", func() {
 		var fakeUnstructured unstructured.Unstructured
 		var manifests []map[string]interface{}

internal/kubernetes/unstructured.go

@@ -2,6 +2,7 @@ package kubernetes
 
 import (
 	"encoding/json"
+	"fmt"
 
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/runtime"
@@ -43,9 +44,32 @@ func ToUnstructured(manifest map[string]interface{}) (unstructured.Unstructured,
 		return unstructured.Unstructured{}, err
 	}
 
-	return unstructured.Unstructured{
+	u := unstructured.Unstructured{
 		Object: m,
-	}, nil
+	}
+
+	// Attempt to get annotations as map[string]string
+	// If no errors then nothing else needs to be done
+	if _, _, err := unstructured.NestedStringMap(u.Object, "metadata", "annotations"); err == nil {
+		return u, nil
+	}
+
+	// Attempt to get annotations as map[string]interface{}
+	annotationsMap, exists, err := unstructured.NestedMap(u.Object, "metadata", "annotations")
+	if err != nil || !exists {
+		return u, err
+	}
+
+	// If annotations exist in manifest and are map[string]interface, convert to map[string]string
+	annotations := make(map[string]string, len(annotationsMap))
+
+	for k, v := range annotationsMap {
+		annotations[k] = fmt.Sprintf("%v", v)
+	}
+
+	u.SetAnnotations(annotations)
+
+	return u, nil
 }
 
 func SetDefaultNamespaceIfScopedAndNoneSet(u *unstructured.Unstructured, helper *resource.Helper) {