Added attention grabbing CSS to the calendar date. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so the date value displayed is based on the data relevant to the wish instead of hardcoded
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
+ Coverage 95.43% 95.47% +0.04%
==========================================
Files 28 28
Lines 394 398 +4
Branches 39 40 +1
==========================================
+ Hits 376 380 +4
Misses 15 15
Partials 3 3
Continue to review full report at Codecov.
|
crstamps2
changed the title
crstamps2
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also made it so the date value displayed is based on the data relevant to the wish instead of hardcoded
What was the feature/problem?
Issue 95
How does this PR address the above feature/problem?
Dates that are the current date will pulse to grab users attention. Additionally date is now a dynamic value instead of static.
Check lists (check
xin[ ]of list items)Additional Comments (if any)
Date was currently a static value set to always be 18. I set it to look at the Wish's created date so it was more dynamic. I am open to changing the attention grabbing method. Just need some solid UX feedback.