Merge pull request #90 from homeport/fix/issue-89

Fix indention issue in type change output

assets/issues/issue-89/expected-dyff-spruce.human

@@ -0,0 +1,14 @@
+
+foo
+  ± type change from map to list
+    - a: 1
+      b: 2
+    + - 1
+      - 2
+
+bar
+  ± type change from map to <nil>
+    - c: 3
+      d: 4
+    + <nil>
+

assets/issues/issue-89/from.yml

@@ -0,0 +1,7 @@
+---
+foo:
+  a: 1
+  b: 2
+bar:
+  c: 3
+  d: 4

assets/issues/issue-89/to.yml

@@ -0,0 +1,5 @@
+---
+foo:
+  - 1
+  - 2
+bar:

pkg/dyff/output_human.go

@@ -251,8 +251,8 @@ func (report *HumanReport) generateHumanDetailOutputModification(detail Detail)
 			return "", err
 		}
 
-		output.WriteString(red("  - %v\n", strings.TrimRight(from, "\n")))
-		output.WriteString(green("  + %v\n", strings.TrimRight(to, "\n")))
+		output.WriteString(red("%s", createStringWithPrefix("  - ", strings.TrimRight(from, "\n"))))
+		output.WriteString(green("%s", createStringWithPrefix("  + ", strings.TrimRight(to, "\n"))))
 	}
 
 	return output.String(), nil

pkg/dyff/output_human_test.go

@@ -173,4 +173,23 @@ variables.ROUTER_TLS_PEM.options
 `)))
 		})
 	})
+
+	Context("reported output issues", func() {
+		BeforeEach(func() {
+			ColorSetting = OFF
+			TrueColorSetting = OFF
+		})
+
+		AfterEach(func() {
+			ColorSetting = AUTO
+			TrueColorSetting = AUTO
+		})
+
+		It("should use correct indentions for all kind of changes", func() {
+			compareAgainstExpected("../../assets/issues/issue-89/from.yml",
+				"../../assets/issues/issue-89/to.yml",
+				"../../assets/issues/issue-89/expected-dyff-spruce.human",
+				false)
+		})
+	})
 })