-
Notifications
You must be signed in to change notification settings - Fork 66
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor global varibales for diff options
The usage of global variables makes it harder to test the package and is generally not the best pattern for non constant settings. Introduce compare options that can optionally be used during the compare to specify the way the comparison is done, for example whether to ignore order changes in lists. Move style settings for Go Patch style and minor change threshold into the report source file. Move code that is only used for the human report into the respective source code file. Introduce test case to show that the identification of non-standard named entry list identifiers can fail if configured differently. Refactor code to match a more common stlye when it comes to multiline instructions with lots of parameters.
- Loading branch information
1 parent
16e3465
commit b2a2e36
Showing
6 changed files
with
213 additions
and
139 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.