chore(plugin-core): print source map revisions message #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subzero10
changed the title
joshuap
requested changes
Nov 18, 2024
| @@ -33,19 +35,21 @@ export async function uploadSourcemaps(sourcemapData: SourcemapInfo[], hbOptions | |||
| const errorsStr = rejected.map(p => p.reason).join('\n') | |||
| throw new Error(`Failed to upload ${rejected.length} sourcemap file(s) to Honeybadger\n${errorsStr}`) | |||
| } | |||
|
|
|||
|
|
|||
| console.info(`Note: For the error to be matched with a source map, the revisions must match. You can learn how to configure honeybadger.js to include the revision here: ${DOCS_VERSIONING_URL}`) | |||
There was a problem hiding this comment.
It looks like we're checking an hbOptions.silent config option for the success message logging. I think we should also respect that here?
There was a problem hiding this comment.
I considered that too, but the silent option is like a debug/verbose flag. My understanding was that we would print this message at all times, not only in debug mode. I don't have a strong opinion though, we can check for silent here as well. Let me know if you want me to go for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Prints a message on successful source maps upload to remind users that Honeybadger needs to be configured with the same revision in order for source maps to match.
Closes: #1417