feat: support for deno.jsonc in vite plugin #253
Merged
+38
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryuapp
changed the title
yusukebe
reviewed
Jan 15, 2025
| } catch {} | ||
| } | ||
| if (!tsConfigRaw) { | ||
| console.warn('Cannot find tsconfig.json or deno.json(c)') |
There was a problem hiding this comment.
I think this console.warn() is okay!
|
Hi @ryuapp Looks good!
Does this mean the errors are still being displayed? |
No. It is not displayed now. I also think that the current simple warning text is good. |
|
Okay! Looks good. I'll merge this and release a new version. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #249
#249 supported for deno.json, but not deno.jsonc. This PR will support for that.
I removed the errors from
console.warn, but I will add it if necessary.There are too many errors to display, so we need some ingenuity.