fix(node-ws): Added missing WSContext raw type (#940)

* node-ws: Added missing WSContext raw type * Updated hono version and added it as peer dependencies * update `package.json` and the lock file * add changeset --------- Co-authored-by: Yusuke Wada <[email protected]>
honojs · Jan 21, 2025 · 3e2db6d · 3e2db6d
1 parent ecb7a1d
commit 3e2db6d
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 12 deletions.
diff --git a/.changeset/metal-kiwis-doubt.md b/.changeset/metal-kiwis-doubt.md
@@ -0,0 +1,5 @@
+---
+'@hono/node-ws': patch
+---
+
+fix: Added missing WSContext raw type
diff --git a/packages/node-ws/package.json b/packages/node-ws/package.json
@@ -34,15 +34,16 @@
   "devDependencies": {
     "@hono/node-server": "^1.11.1",
     "@types/ws": "^8",
-    "hono": "^4.2.9",
+    "hono": "^4.6.0",
     "tsup": "^8.0.1",
     "vitest": "^1.0.4"
   },
   "dependencies": {
     "ws": "^8.17.0"
   },
   "peerDependencies": {
-    "@hono/node-server": "^1.11.1"
+    "@hono/node-server": "^1.11.1",
+    "hono": "^4.6.0"
   },
   "engines": {
     "node": ">=18.14.1"

diff --git a/packages/node-ws/src/index.ts b/packages/node-ws/src/index.ts
@@ -8,7 +8,7 @@ import type { Http2SecureServer, Http2Server } from 'node:http2'
 import { CloseEvent } from './events'
 
 export interface NodeWebSocket {
-  upgradeWebSocket: UpgradeWebSocket
+  upgradeWebSocket: UpgradeWebSocket<WebSocket>
   injectWebSocket(server: Server | Http2Server | Http2SecureServer): void
 }
 export interface NodeWebSocketInit {
@@ -73,7 +73,7 @@ export const createNodeWebSocket = (init: NodeWebSocketInit): NodeWebSocket => {
           const events = await createEvents(c)
           const ws = await nodeUpgradeWebSocket(c.env.incoming)
 
-          const ctx: WSContext = {
+          const ctx: WSContext<WebSocket> = {
             binaryType: 'arraybuffer',
             close(code, reason) {
               ws.close(code, reason)

diff --git a/yarn.lock b/yarn.lock
@@ -2779,12 +2779,13 @@ __metadata:
   dependencies:
     "@hono/node-server": "npm:^1.11.1"
     "@types/ws": "npm:^8"
-    hono: "npm:^4.2.9"
+    hono: "npm:^4.6.0"
     tsup: "npm:^8.0.1"
     vitest: "npm:^1.0.4"
     ws: "npm:^8.17.0"
   peerDependencies:
     "@hono/node-server": ^1.11.1
+    hono: ^4.6.0
   languageName: unknown
   linkType: soft
 
@@ -11818,13 +11819,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"hono@npm:^4.2.9":
-  version: 4.3.3
-  resolution: "hono@npm:4.3.3"
-  checksum: 2e02a563ab8461a56a97b59b1c31fd002179999a0323b3a44cbf8b69b92ad35cc8f38ba26a88b64caa71e2c1c39a1454d84473ed0c69f4e9573e7b3b064e0f58
-  languageName: node
-  linkType: hard
-
 "hono@npm:^4.3.6":
   version: 4.3.6
   resolution: "hono@npm:4.3.6"
@@ -11867,6 +11861,13 @@ __metadata:
   languageName: node
   linkType: hard
 
+"hono@npm:^4.6.0":
+  version: 4.6.17
+  resolution: "hono@npm:4.6.17"
+  checksum: a951eb705841282c16a98ff0b45fb58d2325f945e839ec43c820c29dd380092382781a1fd4590d809a9a0ec9f4df6db738a06bf58c6ce2c279879374d070e2ab
+  languageName: node
+  linkType: hard
+
 "hono@npm:^4.6.10":
   version: 4.6.10
   resolution: "hono@npm:4.6.10"