Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add maximum combo on powermode #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nattaaek
Copy link

Relate from this issue : #55

I have add the maximum combo for powermode

@hyprhare
Copy link
Contributor

hyprhare commented Sep 24, 2020

I don't think that's what CoopTang was talking about:

"Atom has a max combo that saves, but I don't see anything for that in this vscode.
It's nice to be able to see your current combo [progress], but it starts over every time the combo resets."

It's not very clear to me, but I suspect he's talking more about having a visual/reminder of the max-combo you've ever reached?
Perhaps he means displaying the <max_ever_combo> along with the rest of the combo stuff; something like this?

[-----------------------------------------C-O-M-B-O---]
| <motivational_yet_descriptive_combo_progress_text>! |
|          <current_running_combo> / <max_ever_combo> |
[_____________________________________________________]

@nattaaek
Copy link
Author

nattaaek commented Sep 25, 2020

@hyprhare Oh I was misunderstood sorry my English skill is not that good I will take a look Thanks for reply

also I'm newbie for contribute on open source 😅

@hyprhare
Copy link
Contributor

hyprhare commented Oct 1, 2020

@nattaaek
Grace to you friend! 👍 Everyone has things they are working on, and we can all help each other to be our best! 😺

Concerning what you have submitted, I can see a use-case for having a combo cap... I suppose it could feel kinda cool to "max-out" the meter...
Perhaps 99 would be a reasonably achievable default? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants