[HOPS-891] prevent NullPointers in FSNamesystem.getAdditionalDatanode

hopshadoop · Dec 14, 2018 · caf5a40 · caf5a40
1 parent d83173e
commit caf5a40
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/.../main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyDefault.java b/.../main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyDefault.java
@@ -207,8 +207,10 @@ private DatanodeStorageInfo[] chooseTarget(int numOfReplicas,
 
     final List<DatanodeStorageInfo> results = new ArrayList<DatanodeStorageInfo>(chosenStorage);
     for (DatanodeStorageInfo storage : chosenStorage) {
-      // add localMachine and related nodes to excludedNodes
-      addToExcludedNodes(storage.getDatanodeDescriptor(), excludedNodes);
+      if(storage!=null){
+        // add localMachine and related nodes to excludedNodes
+        addToExcludedNodes(storage.getDatanodeDescriptor(), excludedNodes);
+      }
     }
 
     boolean avoidStaleNodes = (stats != null

diff --git a/...roject/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java b/...roject/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
@@ -3165,7 +3165,11 @@ public Object performTask() throws IOException {
 
             //find datanode storages
             final DatanodeManager dm = blockManager.getDatanodeManager();
-            chosen = Arrays.asList(dm.getDatanodeStorageInfos(existings, storageIDs));
+            if(existings.length!=0){
+              chosen = Arrays.asList(dm.getDatanodeStorageInfos(existings, storageIDs));
+            } else {
+              chosen = Collections.<DatanodeStorageInfo>emptyList();
+            }
 
             // choose new datanodes.
             final DatanodeStorageInfo[] targets = blockManager.chooseTarget4AdditionalDatanode(