Skip to content
This repository has been archived by the owner on Jan 14, 2024. It is now read-only.

WIP: Implement parts of MIX #310

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from
Open

WIP: Implement parts of MIX #310

wants to merge 4 commits into from

Conversation

horazont
Copy link
Owner

Goal for this PR is:

  • Create a non-ad-hoc MIX channel
  • Create an ad-hoc MIX channel
  • Join an existing MIX channel
  • Leave a joined MIX channel
  • Send a message through MIX
  • Receive a message through MIX
  • Documentation of aioxmpp.mix, including a fat warning about the experimentalness of the code.

Note that the implementation is tested against ejabberd 19.08, thus we’re not developing against the most recent MIX documents, but against the namespace versions :core:0 and :pam:0.

MIX will be a nice experiment in how we handle namespace bumps in general.

@horazont horazont added work-in-progress (PRs only) Not ready for merge yet. xep-implementation Used with enhancement to mark issues requesting a XEP implementation. labels Sep 16, 2019
@horazont horazont added this to the v0.11 milestone Sep 16, 2019
@horazont horazont self-assigned this Sep 16, 2019
Previously, the code would force coercion of the value through
the *nested* type (in most cases, String) first even if the value
was already an enumeration member. This obviously breaks because
the enumeration member is an instance of the Enumeration and not of
any other type.

This bug occurs only if deprecate_coerce is *false*, because
otherwise there was an additional check for enum membership in the
code path.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
work-in-progress (PRs only) Not ready for merge yet. xep-implementation Used with enhancement to mark issues requesting a XEP implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant