Newlines at end of strings are unexpected #336
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hosseinmoein
requested changes
Nov 4, 2024
Comment on lines
+1156
to
+1161
| if (!value.empty() && value.back() == '\n') { | ||
| value.pop_back(); | ||
| } | ||
| if (!value.empty() && value.back() == '\r') { | ||
| value.pop_back(); | ||
| } |
There was a problem hiding this comment.
Would you mind to generalize this for csv and json formats as well? You can leave the binary format as is
Thanks
There was a problem hiding this comment.
Yes, sure. Will also check if I can add some test cases.
|
Also, please compile the build all binaries in the They must all run without a problem |
On the main branch, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm reading a CSV file
df.read("example.csv", io_format::csv2);:In the data frame, I have newlines
string 1\nfor the last column, which might not match other columns not at the end. For example, when trying to join on string columns.Implemented the logic that Unix-style and Windows-style newlines will be trimmed.