HG-3697: Use GraphQL API for Products Stream #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct int id from string
…tion is unambiguous
nassredean
force-pushed
the
feature/hg-3697
branch
from
1774e0f to
5e4b85f
Compare
nassredean
commented
Jan 17, 2025
| with open(value_map_path, 'r') as file: | ||
| self.value_map = json.load(file) | ||
|
|
||
| def metafields(self, _options=None, **kwargs): |
There was a problem hiding this comment.
This was added to support the metafields stream, which calls this method here.
Unfortunately, it seems that the request shopify.resources.Metafield.find issues looks like this:
https://hotglue-testing-1.myshopify.com/admin/api/2024-01/products/7903137038556/metafields.json?limit=175&since_id=1
Which calls the /products endpoint. Looking into how to resolve this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This pull request changes the implementation of the "Products" stream to use the Shopify GraphQL API. It ensures compatibility with our existing stream schema by leveraging a
ProductCompatibilityclass that handles casting fields and values from the new API to their corresponding equivalent on the legacy API. To support this change, a bump to the ShopifyAPI client was required. A small change was also made to the__init__.pyentrypoint in order to support different Shopify sessions per stream.QA steps
Risks
Rollback steps