HGI-6418 Create data validation for the three required information #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyn4
reviewed
Aug 30, 2024
target_salesforce_v3/sinks.py
Outdated
| f'StageName (pipeline_stage_id: {record.get("pipeline_stage_id")} or status: {record.get("status")}), ' | ||
| f'CloseDate (close_date: {has_close_date})' | ||
| ) | ||
| except Exception as exc: |
There was a problem hiding this comment.
I think it would be better to put the try except on all the preprocess_record logic, because if any case that we didn't consider fails it will stop the job and the state won't be generated.
keyn4
reviewed
Aug 30, 2024
target_salesforce_v3/sinks.py
Outdated
| @@ -391,23 +391,39 @@ class DealsSink(SalesforceV3Sink): | |||
| def reference_data(self): | |||
| params = {"q": "SELECT id, name from Account"} | |||
| response = self.request_api("GET", endpoint="query", params=params) | |||
| response = response.json()["records"] | |||
| response = response.json().get("records",{}) | |||
There was a problem hiding this comment.
if records is not present I think it should default to a list so next line doesn't fail.
butkeraites-hotglue
force-pushed
the
HGI-6418-fix-key-errors-deal-sink
branch
from
49e174b to
73ce384
Compare
butkeraites-hotglue
force-pushed
the
HGI-6418-fix-key-errors-deal-sink
branch
from
73ce384 to
23e8082
Compare
hsyyid
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included data validation for the three required fields:
NameStageNameCloseDateIf the data is not present a message is included in
target_state.json