add read only fields to memory, clean record #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butkeraites-hotglue
requested changes
Sep 12, 2024
There was a problem hiding this comment.
Hey @keyn4 ! Great job! I think we should just add a protection layer for the json.loads but it LGTM :)
target_salesforce_v3/sinks.py
Outdated
| @@ -1010,6 +1014,12 @@ def upsert_record(self, record, context): | |||
| if "INVALID_FIELD_FOR_INSERT_UPDATE" in str(e): | |||
| fields = json.loads(str(e))[0]['fields'] | |||
There was a problem hiding this comment.
This is too generic in my point of view... If the Exception that arises from the try block is not JSON serializable it will raise a json.JSONDecodeError. Should we put this section in a try-except block to handle it?
target_salesforce_v3/sinks.py
Outdated
Comment on lines
1018
to
1021
| if not self._target.read_only_fields.get(self.stream_name): | ||
| self._target.read_only_fields[self.stream_name] = fields | ||
| else: | ||
| self._target.read_only_fields[self.stream_name].extend(fields) |
There was a problem hiding this comment.
Suggested change
| if not self._target.read_only_fields.get(self.stream_name): | |
| self._target.read_only_fields[self.stream_name] = fields | |
| else: | |
| self._target.read_only_fields[self.stream_name].extend(fields) | |
| if not self._target.read_only_fields.get(self.stream_name): | |
| self._target.read_only_fields[self.stream_name] = {} | |
| self._target.read_only_fields[self.stream_name].extend(fields) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.