Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide add project button when signed in as drone operator #79

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

Prajwalism
Copy link
Contributor

No description provided.

@Prajwalism Prajwalism requested a review from varun2948 July 18, 2024 09:15
Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine for the current implementation 👍

But longer term I'm just wondering if we really need to use localStorage to manage the user role?

When we access the frontend we will be authenticating with the backend most likely, so it makes sense to just store the user role in the frontend state.

Plus surely the user role is tied to a specific project, meaning they could be a project manager in one project and a drone operator in another

@varun2948 varun2948 merged commit 257d260 into main Jul 22, 2024
2 checks passed
@varun2948 varun2948 deleted the feat/different-users-flow branch July 22, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants