Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support existing db connections #4

Merged
merged 3 commits into from
Jan 20, 2025
Merged

feat: support existing db connections #4

merged 3 commits into from
Jan 20, 2025

Conversation

emirfabio
Copy link
Contributor

Changes

  • Improved connection management for both internal and external database connections
  • Added support for context manager pattern
  • Added proper cleanup of database connections
  • Added tests

@github-actions github-actions bot added the enhancement New feature or request label Jan 16, 2025
@emirfabio emirfabio changed the title feat: support existing connections feat: support existing db connections Jan 16, 2025
spwoodcock
spwoodcock approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👌

@spwoodcock spwoodcock merged commit 293921b into hotosm:main Jan 20, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spwoodcock spwoodcock spwoodcock approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emirfabio @spwoodcock