Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initialization checks #5

Merged
merged 5 commits into from
Jan 24, 2025
Merged

feat: initialization checks #5

merged 5 commits into from
Jan 24, 2025

Conversation

emirfabio
Copy link
Contributor

Changes

  • Added checks for existing database state before initialization
  • Made initialization idempotent
  • Auto init when used as context manager
  • Added tests for each db state
  • Aligned database connection defaults with compose.yml PostgreSQL credentials
  • Rename to NearestCity

@github-actions github-actions bot added the enhancement New feature or request label Jan 20, 2025
@emirfabio emirfabio changed the title Feature/initialization checks feat: initialization checks Jan 20, 2025
@spwoodcock spwoodcock self-requested a review January 24, 2025 17:12
@spwoodcock
Copy link
Member

Damn, sorry I missed notifications here!!

spwoodcock
spwoodcock approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@spwoodcock spwoodcock left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent stuff!!

I'll merge for now & we can always update after if you agree with my comment 😄

pg_nearest_city/nearest_city.py Show resolved Hide resolved
@spwoodcock spwoodcock merged commit 1687047 into hotosm:main Jan 24, 2025
4 checks passed
@spwoodcock
Copy link
Member

Tests all pass - woop woop 🎉

https://github.com/hotosm/pg-nearest-city/actions/runs/12954345307/job/36136103469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spwoodcock spwoodcock spwoodcock approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emirfabio @spwoodcock