Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Frontend codebase to Typescript and Vite #6715

Draft
wants to merge 130 commits into
base: develop
Choose a base branch
from

Conversation

royallsilwallz
Copy link
Contributor

@royallsilwallz royallsilwallz commented Jan 25, 2025

What type of PR is this?

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI

Related Issue

Describe this PR

This PR includes the following changes -

  • Javascript --> Typescript
  • Craco --> Vite
  • Jest --> Vitest

Led by - @JoltCode πŸš€ ✨

JoltCode and others added 30 commits December 17, 2024 13:04
JoltCode and others added 2 commits January 24, 2025 09:14
@github-actions github-actions bot added dependencies Pull requests that update a dependency file scope: frontend scope: infrastructure labels Jan 25, 2025
@JoltCode
Copy link
Collaborator

Awesome! πŸ‘

@spwoodcock
Copy link
Member

This is fantabulous - seriously great work! πŸŽ†

@royallsilwallz royallsilwallz added the type: enhancement Improving an existing functionality label Jan 26, 2025
@spwoodcock
Copy link
Member

The complaints from SonarCloud are likely not new, but simply showing because we touch a lot of files here right?

My thinking is its nothing to worry about, but would love to hear if @royallsilwallz has any insight?

At the end of the day, I think code quality concerns are bottom of the list - functioning code with adequate tests is more important to me πŸ˜„

@JoltCode
Copy link
Collaborator

The complaints from SonarCloud are likely not new, but simply showing because we touch a lot of files here right?

My thinking is its nothing to worry about, but would love to hear if @royallsilwallz has any insight?

At the end of the day, I think code quality concerns are bottom of the list - functioning code with adequate tests is more important to me πŸ˜„

Yep, I think most of them were already there, but perhaps dismissed? Since the files have been changed from .js -> .ts, and perhaps because we've touched the problem areas, it's reactivated the warnings?

Yep, for now, I think we should ignore them, and address them shortly in a future PR!

@spwoodcock
Copy link
Member

The complaints from SonarCloud are likely not new, but simply showing because we touch a lot of files here right?

My thinking is its nothing to worry about, but would love to hear if @royallsilwallz has any insight?

At the end of the day, I think code quality concerns are bottom of the list - functioning code with adequate tests is more important to me πŸ˜„

Yep, I think most of them were already there, but perhaps dismissed? Since the files have been changed from .js -> .ts, and perhaps because we've touched the problem areas, it's reactivated the warnings?

Yep, for now, I think we should ignore them, and address them shortly in a future PR!

Agree!

I think its because the files have been edited, the checking is triggered, as you say.

So its nothing new introduced, just old issues reflagged (my hunch at least)

@royallsilwallz
Copy link
Contributor Author

royallsilwallz commented Jan 27, 2025

Yes @spwoodcock and @JoltCode , you guys are correct!
We have been ignoring SonarCloud issues in TM, for the frontend at least. πŸ₯Ή

With this PR, we will add strict eslint & prettier lint configs so that we have consistent development setup for all.
Also, we will be fixing lint errors leaving the errors count close to zero. That might help a lot.

Let's see how it goes! 🎯 πŸ˜ƒ

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
21 Security Hotspots
C Reliability Rating on New Code (required β‰₯ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file scope: frontend scope: infrastructure type: enhancement Improving an existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from JavaScript --> TypeScript Replace craco / webpack frontend module bundler with vite
3 participants