-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Frontend codebase to Typescript and Vite #6715
base: develop
Are you sure you want to change the base?
Conversation
typescript-vite: chore(frontend): switch port from 5173 -> 3000
Awesome! π |
This is fantabulous - seriously great work! π |
- Create `useTypedSelector` & `useTypedDispatch` hooks for typescript support - Replace all files with the created hooks
for more information, see https://pre-commit.ci
The complaints from SonarCloud are likely not new, but simply showing because we touch a lot of files here right? My thinking is its nothing to worry about, but would love to hear if @royallsilwallz has any insight? At the end of the day, I think code quality concerns are bottom of the list - functioning code with adequate tests is more important to me π |
Yep, I think most of them were already there, but perhaps dismissed? Since the files have been changed from Yep, for now, I think we should ignore them, and address them shortly in a future PR! |
Agree! I think its because the files have been edited, the checking is triggered, as you say. So its nothing new introduced, just old issues reflagged (my hunch at least) |
Yes @spwoodcock and @JoltCode , you guys are correct! With this PR, we will add strict Let's see how it goes! π― π |
- Upgrade eslint to v9 - Upgrade prettier to v3 - Setup config files with latest standards
- Address `no-unused-vars` lint errors
a076ed6
to
255a641
Compare
typescript-vite: fix(frontend/tests): remove readdition of server-handlers.js, rename ohsome url constant var
|
What type of PR is this?
Related Issue
craco
/webpack
frontend module bundler withvite
Β #6531Describe this PR
This PR includes the following changes -
Led by - @JoltCode π β¨