Merge pull request #65 from hotstreams/fix/hidden-scene-instances

fix hidden scene instances not being hidden
hotstreams · Jun 19, 2024 · aacdb3c · aacdb3c
2 parents 4026338 + 08e46d7
commit aacdb3c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/include/limitless/scene.hpp b/include/limitless/scene.hpp
@@ -54,6 +54,9 @@ namespace Limitless {
         std::shared_ptr<Skybox>& getSkybox() noexcept;
         void setSkybox(const std::shared_ptr<Skybox>& skybox);
 
+        /**
+         * Return visible scene instances.
+         */
         Instances getInstances() const noexcept;
 
         void update(Context& context, const Camera& camera);

diff --git a/src/limitless/scene.cpp b/src/limitless/scene.cpp
@@ -140,6 +140,9 @@ Instances Scene::getInstances() const noexcept {
     };
 
 	for (const auto& [_, instance] : instances) {
+        if (instance->isHidden()) {
+            continue;
+        }
 		visitor(*instance);
 	}