This repository has been archived by the owner on Dec 26, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a readthrough of the repo. All in all I think it looks good, you do some clever things.
Some improvements that could possibly be made is to have settings for two things.
javascript
is a pretty reasonable name.If I've got several django apps, will it work correctly? I assume that the stimulus command will create several
application.js
if you do it for several django apps. I haven't tried, but when reading through the code that's what I asked myself.Have a watch command.