-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SauceLabs firefox latest
tests in CI
#601
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzak
added a commit
to zzak/rails
that referenced
this pull request
Oct 5, 2024
Changes to the config were required to get latest firefox running: https://saucelabs.com/resources/blog/update-firefox-tests-before-oct-4-2022 Thanks to hotwired/stimulus#601 and trix I was able to get the config working, the secret was that resolution for `webdriverio` needs to go in the root `package.json`. In the short-to-mid term I'd like to explore updating our builds to use the latest yarn, or remove it entirely, as that seems to be a common thread in these issues. There was another investigation into mitigating the flaky saucelabs failures in rails#51990 but I think let's make sure we're on the latest version and browsers to see if that improves things or provides new and interesting error states first.
zzak
added a commit
to zzak/rails
that referenced
this pull request
Oct 5, 2024
Changes to the config were required to get latest firefox running: https://saucelabs.com/resources/blog/update-firefox-tests-before-oct-4-2022 Thanks to hotwired/stimulus#601 and trix I was able to get the config working, the secret was that resolution for `webdriverio` needs to go in the root `package.json`. In the short-to-mid term I'd like to explore updating our builds to use the latest yarn, or remove it entirely, as that seems to be a common thread in these issues. There was another investigation into mitigating the flaky saucelabs failures in rails#51990 but I think let's make sure we're on the latest version and browsers to see if that improves things or provides new and interesting error states first.
zzak
added a commit
to zzak/rails
that referenced
this pull request
Oct 5, 2024
Changes to the config were required to get latest firefox running: https://saucelabs.com/resources/blog/update-firefox-tests-before-oct-4-2022 Thanks to hotwired/stimulus#601 and trix I was able to get the config working, the secret was that resolution for `webdriverio` needs to go in the root `package.json`. In the short-to-mid term I'd like to explore updating our builds to use the latest yarn, or remove it entirely, as that seems to be a common thread in these issues. There was another investigation into mitigating the flaky saucelabs failures in rails#51990 but I think let's make sure we're on the latest version and browsers to see if that improves things or provides new and interesting error states first.
zzak
added a commit
to zzak/rails
that referenced
this pull request
Oct 5, 2024
Changes to the config were required to get latest firefox running: https://saucelabs.com/resources/blog/update-firefox-tests-before-oct-4-2022 Thanks to hotwired/stimulus#601 and trix I was able to get the config working, the secret was that resolution for `webdriverio` needs to go in the root `package.json`. In the short-to-mid term I'd like to explore updating our builds to use the latest yarn, or remove it entirely, as that seems to be a common thread in these issues. There was another investigation into mitigating the flaky saucelabs failures in rails#51990 but I think let's make sure we're on the latest version and browsers to see if that improves things or provides new and interesting error states first.
zzak
added a commit
to zzak/rails
that referenced
this pull request
Oct 5, 2024
Changes to the config were required to get latest firefox running: https://saucelabs.com/resources/blog/update-firefox-tests-before-oct-4-2022 Thanks to hotwired/stimulus#601 and trix I was able to get the config working, the secret was that resolution for `webdriverio` needs to go in the root `package.json`. In the short-to-mid term I'd like to explore updating our builds to use the latest yarn, or remove it entirely, as that seems to be a common thread in these issues. There was another investigation into mitigating the flaky saucelabs failures in rails#51990 but I think let's make sure we're on the latest version and browsers to see if that improves things or provides new and interesting error states first.
zzak
added a commit
to zzak/rails
that referenced
this pull request
Oct 5, 2024
Changes to the config were required to get latest firefox running: https://saucelabs.com/resources/blog/update-firefox-tests-before-oct-4-2022 Thanks to hotwired/stimulus#601 and trix I was able to get the config working, the secret was that resolution for `webdriverio` needs to go in the root `package.json`. In the short-to-mid term I'd like to explore updating our builds to use the latest yarn, or remove it entirely, as that seems to be a common thread in these issues. There was another investigation into mitigating the flaky saucelabs failures in rails#51990 but I think let's make sure we're on the latest version and browsers to see if that improves things or provides new and interesting error states first.
zzak
added a commit
to rails/rails
that referenced
this pull request
Oct 5, 2024
Changes to the config were required to get latest firefox running: https://saucelabs.com/resources/blog/update-firefox-tests-before-oct-4-2022 Thanks to hotwired/stimulus#601 and trix I was able to get the config working, the secret was that resolution for `webdriverio` needs to go in the root `package.json`. In the short-to-mid term I'd like to explore updating our builds to use the latest yarn, or remove it entirely, as that seems to be a common thread in these issues. There was another investigation into mitigating the flaky saucelabs failures in #51990 but I think let's make sure we're on the latest version and browsers to see if that improves things or provides new and interesting error states first.
zzak
added a commit
to zzak/rails
that referenced
this pull request
Oct 5, 2024
Changes to the config were required to get latest firefox running: https://saucelabs.com/resources/blog/update-firefox-tests-before-oct-4-2022 Thanks to hotwired/stimulus#601 and trix I was able to get the config working, the secret was that resolution for `webdriverio` needs to go in the root `package.json`. In the short-to-mid term I'd like to explore updating our builds to use the latest yarn, or remove it entirely, as that seems to be a common thread in these issues. There was another investigation into mitigating the flaky saucelabs failures in rails#51990 but I think let's make sure we're on the latest version and browsers to see if that improves things or provides new and interesting error states first.
zzak
added a commit
to zzak/rails
that referenced
this pull request
Oct 5, 2024
Changes to the config were required to get latest firefox running: https://saucelabs.com/resources/blog/update-firefox-tests-before-oct-4-2022 Thanks to hotwired/stimulus#601 and trix I was able to get the config working, the secret was that resolution for `webdriverio` needs to go in the root `package.json`. In the short-to-mid term I'd like to explore updating our builds to use the latest yarn, or remove it entirely, as that seems to be a common thread in these issues. There was another investigation into mitigating the flaky saucelabs failures in rails#51990 but I think let's make sure we're on the latest version and browsers to see if that improves things or provides new and interesting error states first.
zzak
added a commit
to zzak/rails
that referenced
this pull request
Oct 6, 2024
Changes to the config were required to get latest firefox running: https://saucelabs.com/resources/blog/update-firefox-tests-before-oct-4-2022 Thanks to hotwired/stimulus#601 and trix I was able to get the config working, the secret was that resolution for `webdriverio` needs to go in the root `package.json`. In the short-to-mid term I'd like to explore updating our builds to use the latest yarn, or remove it entirely, as that seems to be a common thread in these issues. There was another investigation into mitigating the flaky saucelabs failures in rails#51990 but I think let's make sure we're on the latest version and browsers to see if that improves things or provides new and interesting error states first.
zzak
added a commit
to zzak/rails
that referenced
this pull request
Oct 6, 2024
Changes to the config were required to get latest firefox running: https://saucelabs.com/resources/blog/update-firefox-tests-before-oct-4-2022 Thanks to hotwired/stimulus#601 and trix I was able to get the config working, the secret was that resolution for `webdriverio` needs to go in the root `package.json`. In the short-to-mid term I'd like to explore updating our builds to use the latest yarn, or remove it entirely, as that seems to be a common thread in these issues. There was another investigation into mitigating the flaky saucelabs failures in rails#51990 but I think let's make sure we're on the latest version and browsers to see if that improves things or provides new and interesting error states first.
zzak
added a commit
to zzak/rails
that referenced
this pull request
Oct 6, 2024
Changes to the config were required to get latest firefox running: https://saucelabs.com/resources/blog/update-firefox-tests-before-oct-4-2022 Thanks to hotwired/stimulus#601 and trix I was able to get the config working, the secret was that resolution for `webdriverio` needs to go in the root `package.json`. In the short-to-mid term I'd like to explore updating our builds to use the latest yarn, or remove it entirely, as that seems to be a common thread in these issues. There was another investigation into mitigating the flaky saucelabs failures in rails#51990 but I think let's make sure we're on the latest version and browsers to see if that improves things or provides new and interesting error states first.
zzak
added a commit
to zzak/rails
that referenced
this pull request
Oct 6, 2024
Changes to the config were required to get latest firefox running: https://saucelabs.com/resources/blog/update-firefox-tests-before-oct-4-2022 Thanks to hotwired/stimulus#601 and trix I was able to get the config working, the secret was that resolution for `webdriverio` needs to go in the root `package.json`. In the short-to-mid term I'd like to explore updating our builds to use the latest yarn, or remove it entirely, as that seems to be a common thread in these issues. There was another investigation into mitigating the flaky saucelabs failures in rails#51990 but I think let's make sure we're on the latest version and browsers to see if that improves things or provides new and interesting error states first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes the CI by updating the config for SauceLabs
firefox latest
.SauceLabs upgraded their
geckodriver
version on Oct 4th which made our builds fail:https://saucelabs.com/blog/update-firefox-tests-before-oct-4-2022
Technically this would have been fixed by providing the
"moz:debuggerAddress": true
capability for geckodriver version>= 0.31.0
.But since the latest
karma-sauce-launcher
version depends on an older version ofwebdriverio
which doesn't apply this config properly when sending the options to SauceLabs that didn't work.Forcing
webdriverio
to version>= 7.19.5
solves this issue. This is now achieved via adding a resolution to ourpackage.json
for thewebdriverio
package.This Pull Request additionally updates all the karma-related dependencies to the latest versions and updates the karma config to comply with the new "w3c WebDriver capabilities".
For additional context see: karma-runner/karma-sauce-launcher#275