Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve workflow step names #1658

Merged
merged 1 commit into from
Sep 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ concurrency:
cancel-in-progress: true
jobs:
build:
name: "Build"
uses: "./.github/workflows/single-matrix-pr.yml"
with:
os: ${{ matrix.os }}
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/single-matrix-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:
filters: .github/path-filters.yml

package-download:
name: "Package caching"
uses: "./.github/workflows/cache-packages.yml"
needs: changes
with:
Expand All @@ -46,7 +47,8 @@ jobs:
- name: Run markdownlint
run: yarn markdownlint

main_build:
ruby_build:
name: "Ruby build and spec"
needs:
- package-download
- changes
Expand Down Expand Up @@ -75,6 +77,7 @@ jobs:
run: bin/rails assets:precompile

webpack:
name: "Webpack JS files"
needs: package-download
if: ${{ contains(needs.changes.outputs.filters, 'build-js') }}
runs-on: ${{ inputs.os }}
Expand All @@ -94,6 +97,7 @@ jobs:
run: yarn build-storybook

jest:
name: "Jest for JS"
needs: package-download
if: ${{ contains(needs.changes.outputs.filters, 'build-js') }}
runs-on: ${{ inputs.os }}
Expand Down
Loading