Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: assets ending in ".$OS.$ARCH" #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: assets ending in ".$OS.$ARCH" #71

wants to merge 1 commit into from

Conversation

jdx
Copy link

@jdx jdx commented Oct 28, 2024

@autarch
Copy link
Member

autarch commented Nov 3, 2024

Hi, thanks for your PR! I'm pretty finicky about my projects (see this blog post for details), so I rarely merge a PR as-is. I can move forward on your PR in one of two ways:

  1. I check it out locally, fiddle with it as needed, merge it locally, and simply close this PR. This will preserve at least one commit with your name on it, but the PR will show up as closed in your GitHub stats.
  2. If you enable me to push directly to your fork, I can do my fiddling, then force push to your fork and merge the resulting PR. Again, this will preserve at least one commit with your name on it, but you also get credit for the PR merge in your GitHub stats. The only downside is that I will be force pushing directly to your fork.

Please let me know which approach you'd prefer. If I don't hear from you before I get around to working on this PR I'll go with option #1.

Thanks again for your contribution!

autarch
autarch requested changes Nov 3, 2024
View reviewed changes
Copy link
Member

@autarch autarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix. This looks good % some small stuff. I can make the changes myself or you can do it if you'd prefer. Please let me know.

ubi/src/os.rs Outdated Show resolved Hide resolved
ubi/src/os.rs Outdated
Comment on lines 72 to 80
pub(crate) static PLATFORM_RE: Lazy<Regex> = Lazy::new(|| {
Regex::new(
&[all_oses_re(), all_arches_re()]
.iter()
.map(|r| format!("({})", r.as_str()))
.join("|"),
)
.unwrap()
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be constructed in the extension module by importing the relevant fns from os and arch.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk how significant it is but won't that involve recompiling the final regex many times?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autarch autarch autarch requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mise fails to install sops >=3.8.1 via ubi
2 participants
@jdx @autarch