Fix transparency issues on Windows 10 #1412
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: closes #1405
Requirements
node
version specified inpackage.json
was used (ie using nvm).npm install --no-save
).npm run lint
reports no offenses.npm run test
is error-free.Description of the Change
Verification Process
Based on that issue in Electron: electron/electron#8847
I was able to fix the issue by setting the transparency to True always and HasShadow = false.
However, since the application has a transparency setting, I've updated the method to calculate the background color to check for the transparency setting. Note, that it was tested only on Win10
Other information