This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
bucache: save and restore xattrs, ACLs #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaudill
changed the title
reidpr
suggested changes
Jul 5, 2023
lib/charliecloud.py
Outdated
| @@ -599,9 +599,10 @@ def exit(code): | |||
|
|
|||
| def init(cli): | |||
| # logging | |||
| global log_festoon, log_fp, trace_fatal, verbose | |||
| global log_festoon, log_fp, trace_fatal, verbose, xattrs | |||
There was a problem hiding this comment.
I bet you haven't worked on any other projects with a variable named festoon lol.
Co-authored-by: Reid Priedhorsky <[email protected]>
Co-authored-by: Reid Priedhorsky <[email protected]>
Co-authored-by: Reid Priedhorsky <[email protected]>
lucaudill
changed the title
reidpr
suggested changes
Aug 18, 2023
test/run/ch-convert.bats
Outdated
| cd "$BATS_TMPDIR" | ||
|
|
||
| borked_img="borked_image" | ||
| borked_file="$borked_img/home/foo" |
There was a problem hiding this comment.
Style:
Suggested change
| borked_file="$borked_img/home/foo" | |
| borked_file="${borked_img}/home/foo" |
Also I recommend a directory other than /home because that gets special treatment sometimes.
reidpr
approved these changes
Aug 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1287