This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
Fix docker check if docker is a wrapper for podman #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should fix issue #1656 |
|
What's the magic to get the tests to pass for this simple PR? |
reidpr
reviewed
Aug 23, 2023
There was a problem hiding this comment.
Pat, thanks for the patch. I am sorry to let it sit so long. @mphinney1100 referred the brackets problem to me. Indeed, this caused the test failure. Changing to single brackets made the glob pattern not work any more, so I pushed an alternative. Also I moved the error message to later.
Can you please try the changed PR and let us know if it works for you?
|
This time the test failure is spurious (see PR #1707). |
|
Thank you for the fix. It does work on the system that we encountered problems on. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the docker check if there is a docker wrapper for podman.