Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch ddup hashing algorithm to xxHash #538

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

theAeon
Copy link

@theAeon theAeon commented Oct 18, 2022

improves performance massively and moots #535

Signed-off-by: Andrew Robbins [email protected]

Signed-off-by: Andrew Robbins [email protected]
revert strcpy, fix library linking

properly print hash digest strings

fix segfault on crash

housekeeping

Signed-off-by: Andrew Robbins [email protected]
fixed cmake for vendored xxhash

Signed-off-by: Andrew Robbins [email protected]
@theAeon
Copy link
Author

theAeon commented Jul 6, 2023

Just a quick update on the viability of this:

it seems that xxhash runs so quickly that the threads start clobbering each others' output in the outfile. might need a bit of parallelism reworking that wasn't necessary w/ a secure hash like sha256.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant