MFU-578: add xattr.h header to mfu_io.c #582
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include the xattr.h header in mfu_io.c to avoid compilation errors (ISO C99 and later do not support implicit function declarations) Signed-off-by: Michael Hennecke <[email protected]>
daltonbohning
requested changes
Aug 22, 2024
There was a problem hiding this comment.
If we do this I think it still needs to be behind the xattr compile flag.
E.g.
mpifileutils/src/common/mfu_flist_archive.c
Lines 35 to 37 in 0a4c530
Then, the real fix to your #578 is to also wrap the uses of the xattr functions.
A workaround is to just build with -DENABLE_XATTRS=ON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include the xattr.h header in mfu_io.c to avoid compilation errors (ISO C99 and later do not support implicit function declarations)